Place semicolon before inline comment#197
Open
rwestMSFT wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Transact-SQL script generator to ensure that semicolons are correctly placed before any trailing comments (both single-line and block comments) when generating SQL scripts with preserved comments. This prevents semicolons from being included as part of a comment, which could cause issues in SQL execution or readability.
The changes introduce a new method (
GenerateStatementWithSemiColon) to handle this logic, and update all relevant code paths to use it._suppressTrailingCommentsand_suppressTrailingCommentsAfterIndex) and logic to theSqlScriptGeneratorVisitorto allow deferring the emission of trailing comments until after the semicolon is generated, ensuring the semicolon is not included in the comment text. [1] [2] [3]GenerateStatementWithSemiColonmethod, which generates a statement, emits the semicolon, and then emits any trailing comments. This method is now used in place of the previous approach wherever statements and their semicolons are generated.IfStatement,StatementList,TSqlBatch,WhileStatement) to useGenerateStatementWithSemiColoninstead of the old pattern, ensuring consistent semicolon placement before comments throughout the codebase. [1] [2] [3] [4] [5](This description was generated with the assistance of Copilot.)
In addition, go through the checklist below and check each item as you validate it is either handled or not applicable to this change.
Code Changes